Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage SourceMap API #36089

Merged
merged 0 commits into from
Nov 24, 2020
Merged

test: improve test coverage SourceMap API #36089

merged 0 commits into from
Nov 24, 2020

Conversation

juanarbol
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 11, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34392/

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34512/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34516/

@Trott
Copy link
Member

Trott commented Nov 24, 2020

Landed in 68795f9

@Trott Trott closed this Nov 24, 2020
@Trott Trott force-pushed the juanarbol/improve-sourcemaps-coverage branch from aae4bbe to 68795f9 Compare November 24, 2020 12:44
@Trott Trott merged commit 68795f9 into nodejs:master Nov 24, 2020
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@juanarbol @danielleadams
test: improve test coverage SourceMap API
69a8f05 
PR-URL: #36089
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/improve-sourcemaps-coverage branch January 19, 2021 16:26
targos pushed a commit that referenced this pull request May 1, 2021
@juanarbol @targos
test: improve test coverage SourceMap API
94a877b 
PR-URL: #36089
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanarbol @nodejs-github-bot @Trott @himself65