-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move v8.getHeapCodeStatistics() #36027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
approved these changes
Nov 7, 2020
benjamingr
approved these changes
Nov 7, 2020
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Nov 7, 2020
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 9, 2020
14 tasks
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: nodejs#36027 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Trott
force-pushed
the
v8-partial-alpha
branch
from
November 10, 2020 13:29
23e7fe6
to
270a02c
Compare
Landed in 270a02c |
danielleadams
pushed a commit
that referenced
this pull request
Nov 10, 2020
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: #36027 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: #36027 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: #36027 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: #36027 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
An effort to alphabetize all the entries met some resistance on the
grounds that it put some things in an order that wasn't logical, but
this one should be uncontroversial, I think.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes