test: use global.EventTarget instead of internals #36002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
targos
added
dont-land-on-v10.x
request-ci
targos
approved these changes
Nov 7, 2020
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
benjamingr
approved these changes
Nov 7, 2020
aduh95
added
the
author ready
`EventTarget` is exposed on the global scope, there is no need to use `--expose-internals` flag in the tests. Refs: nodejs#35496 PR-URL: nodejs#36002 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
aduh95
force-pushed
the
test-global-eventtarget
branch
from
06bd33a
to
36fbbe0
Compare
|
Landed in 36fbbe0 |
danielleadams
pushed a commit
that referenced
this pull request
Nov 10, 2020
`EventTarget` is exposed on the global scope, there is no need to use `--expose-internals` flag in the tests. Refs: #35496 PR-URL: #36002 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventTargetandEventare available from the global scope, there is no need to use the--expose-internalsflag in the tests.Refs: #35496
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes