Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: refactor to use more primordials #35998

Closed
wants to merge 1 commit into from
Closed

assert: refactor to use more primordials #35998

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 6, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Nov 6, 2020
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34146/

@aduh95 aduh95 added the review wanted PRs that need reviews. label Nov 8, 2020
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 10, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2020
@github-actions
Copy link
Contributor

Landed in 8656ab4...d8f66c1

@github-actions github-actions bot closed this Nov 13, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 13, 2020
@aduh95 @nodejs-github-bot
assert: refactor to use more primordials
d8f66c1 
PR-URL: #35998
Reviewed-By: Rich Trott <[email protected]>
@aduh95 aduh95 deleted the assert-more-primodials branch November 14, 2020 10:32
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@aduh95 @codebytere
assert: refactor to use more primordials
34aa0c8 
PR-URL: #35998
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@aduh95 @BethGriggs
assert: refactor to use more primordials
b602360 
PR-URL: #35998
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@aduh95 @BethGriggs
assert: refactor to use more primordials
64723a3 
PR-URL: #35998
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@aduh95 @BethGriggs
assert: refactor to use more primordials
c508bfc 
PR-URL: #35998
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @nodejs-github-bot @Trott