dns: fix trace_events name for resolveCaa() #35979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
approved these changes
Nov 5, 2020
github-actions
bot
removed
the
request-ci
Whoops, that was against master and shows the failure. Here's against this PR to show success: Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17425/ ✅ |
|
@nodejs/testing @nodejs/dns This fixes the node-daily-master CI job. One more review/approval would be helpful. |
cjihrig
approved these changes
Nov 8, 2020
A test was added for this in 6f34498 but because it was a test in the `internet` directory, it was not run on CI and it was not noticed that the test was failing. This fixes the error that was causing the test to fail. PR-URL: nodejs#35979 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 642174a |
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
A test was added for this in 6f34498 but because it was a test in the `internet` directory, it was not run on CI and it was not noticed that the test was failing. This fixes the error that was causing the test to fail. PR-URL: #35979 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
A test was added for this in 6f34498 but because it was a test in the `internet` directory, it was not run on CI and it was not noticed that the test was failing. This fixes the error that was causing the test to fail. PR-URL: #35979 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test was added for this in 6f34498 but because it was a test in the
internetdirectory, it was not run on CI and it was not noticed thatthe test was failing. This fixes the error that was causing the test to
fail.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes