Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix error in test/internet/test-dns.js #35969

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 4, 2020

Refs: #35466 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2020
@Trott
Copy link
Member Author

Trott commented Nov 4, 2020

Fast-track to fix failing test in node-daily-master?

@Trott
Copy link
Member Author

Trott commented Nov 4, 2020

Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17343/

There's a different DNS test that I expect to still fail but this one should now pass.

@Trott Trott mentioned this pull request Nov 4, 2020
4 tasks
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystem should be test instead of doc but otherwise 👍.

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 4, 2020
@Trott
Copy link
Member Author

Trott commented Nov 5, 2020

Subsystem should be test instead of doc but otherwise 👍.

Fixed. Thanks.

@Trott Trott changed the title doc: fix error in test/internet/test-dns.js test: fix error in test/internet/test-dns.js Nov 5, 2020
Refs: nodejs#35466 (comment)

PR-URL: nodejs#35969
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 5, 2020

Landed in 088dfce

@Trott Trott merged commit 088dfce into nodejs:master Nov 5, 2020
@Trott Trott deleted the fix-test-dns branch November 5, 2020 13:51
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
Refs: #35466 (comment)

PR-URL: #35969
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
targos pushed a commit that referenced this pull request May 1, 2021
Refs: #35466 (comment)

PR-URL: #35969
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants