Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick 9a49b22 from V8 upstream #35939

Closed
wants to merge 2 commits into from
Closed

deps: cherry-pick 9a49b22 from V8 upstream #35939

wants to merge 2 commits into from

Commits on Nov 3, 2020

  1. deps: cherry-pick 9a49b22 from V8 upstream 

    Original commit message:
  Fix alloc/dealloc size mismatch for v8::BackingStore

  On newer compilers the {operator delete} with explicit {size_t}
  argument would be instantiated for {v8::BackingStore} and used
  in the destructor of {std::unique_ptr<v8::BackingStore>}. The {size_t}
  argument is wrong though, since the pointer actually points
  to a {v8::internal::BackingStore} object.
  The solution is to explicitly provide a {operator delete}, preventing
  an implicitly generated {size_t} operator.

  Bug:v8:11081

  Change-Id: Iee0aa47a67f0e41000bea628942f7e3d70198b83
  Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2506712
  Commit-Queue: Ulan Degenbaev <[email protected]>
  Reviewed-by: Camillo Bruni <[email protected]>
  Cr-Commit-Position: refs/heads/master@{#70916}

Refs: v8/v8@9a49b22
Fixes: nodejs#35669
    @danbev
    danbev committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    d9e2331 View commit details
    Browse the repository at this point in the history

  2. squash: increment v8_embedder_string

    @danbev
    danbev committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    72fbe65 View commit details
    Browse the repository at this point in the history