Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, build: fix build time on Windows #35932

Closed
wants to merge 1 commit into from
Closed

win, build: fix build time on Windows #35932

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Nov 2, 2020

Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0.

Fixes: #35921

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@bzoz
win, build: fix build time on Windows
c581197 
Sets MSBuild experimental switches to make it build in parallel project
files generated by gyp 0.5.0.

Fixes: nodejs#35921
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Nov 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34023/

@bzoz bzoz mentioned this pull request Nov 2, 2020
Closed
@richardlau
Copy link
Member

@bzoz Will these changes work for VS 2017? If not, we should add appropriate dont-land-on-v14.x etc labels.

@bzoz
Copy link
Contributor Author

bzoz commented Nov 2, 2020

@richardlau the thread where those are mentioned is about VS2017, so I guess they should work. I'll give it a try.

@bzoz
Copy link
Contributor Author

bzoz commented Nov 2, 2020

This does not have any effect on VS2017. The build works, but it is still slow.

himself65
himself65 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzoz bzoz mentioned this pull request Nov 5, 2020
Closed
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2020
@bzoz @Trott
win, build: fix build time on Windows
bfc9847 
Sets MSBuild experimental switches to make it build in parallel project
files generated by gyp 0.5.0.

Fixes: nodejs#35921

PR-URL: nodejs#35932
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 7, 2020

Landed in bfc9847

@Trott Trott closed this Nov 7, 2020
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@bzoz @danielleadams
win, build: fix build time on Windows
7a2edea 
Sets MSBuild experimental switches to make it build in parallel project
files generated by gyp 0.5.0.

Fixes: #35921

PR-URL: #35932
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@bzoz @BethGriggs
win, build: fix build time on Windows
eb4cb46 
Sets MSBuild experimental switches to make it build in parallel project
files generated by gyp 0.5.0.

Fixes: #35921

PR-URL: #35932
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@bzoz @BethGriggs
win, build: fix build time on Windows
5227aba 
Sets MSBuild experimental switches to make it build in parallel project
files generated by gyp 0.5.0.

Fixes: #35921

PR-URL: #35932
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@bzoz @BethGriggs
win, build: fix build time on Windows
ffe517b 
Sets MSBuild experimental switches to make it build in parallel project
files generated by gyp 0.5.0.

Fixes: #35921

PR-URL: #35932
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

windows: gyp 0.5.0 made build time multiple times slower
9 participants
@bzoz @nodejs-github-bot @richardlau @Trott @addaleax @cjihrig @gengjiawen @gireeshpunathil @himself65