Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix link with openssl on centos 6 #35917

Closed
wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Nov 2, 2020

Many products have this error on linkage:
undefined reference to 'clock_gettime'

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Many products have this error on linkage:
undefined reference to `clock_gettime`
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 2, 2020
@Trott
Copy link
Member

Trott commented Nov 2, 2020

Welcome @orgads and thanks for the pull request. Building Node.js requires CentOS 7 or higher. CentOS 6 is end-of-life this month.

@nodejs/build Should this be closed? Or would we consider landing it as an accommodation even though we don't support CentOS 6?

@richardlau
Copy link
Member

FWIW it wasn't specifically for openssl but we dropped -lrt in #29727.

Welcome @orgads and thanks for the pull request. Building Node.js requires CentOS 7 or higher. CentOS 6 is end-of-life this month.

@nodejs/build Should this be closed? Or would we consider landing it as an accommodation even though we don't support CentOS 6?

I'd vote for close.

@orgads
Copy link
Contributor Author

orgads commented Nov 2, 2020

Ok

@orgads orgads closed this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants