Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: do not call resolve on URLs with schemes #35903

Closed
wants to merge 10 commits into from
Closed

errors: do not call resolve on URLs with schemes #35903

wants to merge 10 commits into from

Commits on Oct 31, 2020

  1. errors: do not call resolve on URLs with schemes 

    Based on advice from webpack project, this PR stops trying to resolve
sources with a webpack:// scheme (or other schemes, as they represent
absolute URLs). Source content is now loaded from the sourcesContent
lookup, if it is populated (allowing for non file:// schemes).

Refs: nodejs#35325
    @bcoe
    bcoe committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    44f20fc View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2020

  1. Update lib/internal/source_map/source_map_cache.js 

    Co-authored-by: devsnek <[email protected]>
    @bcoe @devsnek
    bcoe and devsnek authored Nov 1, 2020
    Configuration menu
    Copy the full SHA
    dd0949f View commit details
    Browse the repository at this point in the history

  2. Update lib/internal/source_map/prepare_stack_trace.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @bcoe @aduh95
    bcoe and aduh95 authored Nov 1, 2020
    Configuration menu
    Copy the full SHA
    3e78647 View commit details
    Browse the repository at this point in the history

  3. Update lib/internal/source_map/prepare_stack_trace.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @bcoe @aduh95
    bcoe and aduh95 authored Nov 1, 2020
    Configuration menu
    Copy the full SHA
    596cf2a View commit details
    Browse the repository at this point in the history

  4. Update lib/internal/source_map/source_map_cache.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @bcoe @aduh95
    bcoe and aduh95 authored Nov 1, 2020
    Configuration menu
    Copy the full SHA
    8933b5c View commit details
    Browse the repository at this point in the history

  5. Update lib/internal/source_map/prepare_stack_trace.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @bcoe @aduh95
    bcoe and aduh95 authored Nov 1, 2020
    Configuration menu
    Copy the full SHA
    6ace772 View commit details
    Browse the repository at this point in the history

  6. errors: use URL for resolution

    @bcoe
    bcoe committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    21124ef View commit details
    Browse the repository at this point in the history

  7. chore: address code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @bcoe @aduh95
    bcoe and aduh95 authored Nov 1, 2020
    Configuration menu
    Copy the full SHA
    3c1a7ca View commit details
    Browse the repository at this point in the history

  8. chore: fix linting

    @bcoe
    bcoe committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    eafd35e View commit details
    Browse the repository at this point in the history

  9. chore: fix path resolution

    @bcoe
    bcoe committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    c85b480 View commit details
    Browse the repository at this point in the history