Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing ref comments to parallel.status #35896

Merged
merged 1 commit into from
Nov 4, 2020
Merged

test: add missing ref comments to parallel.status #35896

merged 1 commit into from
Nov 4, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 31, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 31, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33997/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34016/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34038/

@Trott
test: add missing ref comments to parallel.status
72ce5dc 
PR-URL: nodejs#35896
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 4, 2020

Landed in 72ce5dc

@Trott Trott merged commit 72ce5dc into nodejs:master Nov 4, 2020
@Trott Trott deleted the parallel-refs branch November 4, 2020 12:58
targos pushed a commit that referenced this pull request Nov 4, 2020
@Trott @targos
test: add missing ref comments to parallel.status
5d61e3d 
PR-URL: #35896
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 4, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@Trott @BethGriggs
test: add missing ref comments to parallel.status
cd1c629 
PR-URL: #35896
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott @BethGriggs
test: add missing ref comments to parallel.status
2443e9c 
PR-URL: #35896
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott @BethGriggs
test: add missing ref comments to parallel.status
de375e1 
PR-URL: #35896
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @benjamingr @lpinca @gireeshpunathil