lib, test: integrate wpt abort_controller tests and fix onabort event #35869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
added
events
Trott
approved these changes
Oct 29, 2020
targos
approved these changes
Oct 29, 2020
benjamingr
approved these changes
Oct 29, 2020
benjamingr
reviewed
Oct 29, 2020
benjamingr
reviewed
Oct 29, 2020
benjamingr
requested changes
Oct 29, 2020
The AbortController abort event should have EventTarget as a target property of the argument event.
github-actions
bot
removed
the
request-ci
benjamingr
reviewed
Oct 31, 2020
benjamingr
approved these changes
Oct 31, 2020
github-actions
bot
removed
the
request-ci
watilde
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35869 ✔ Done loading data for nodejs/node/pull/35869 ----------------------------------- PR info ------------------------------------ Title lib, test: integrate wpt abort_controller tests and fix onabort event (#35869) Author Daijiro Wachi (@watilde) Branch watilde:wpt-abort -> nodejs:master Labels events, lib / src, test Commits 2 - lib: let abort_controller target be EventTarget - test: integrate abort_controller tests from wpt Committers 1 - Daijiro Wachi PR-URL: https://github.com/nodejs/node/pull/35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-31T09:16:09Z: https://ci.nodejs.org/job/node-test-pull-request/33988/ - Querying data for job/node-test-pull-request/33988/ ✔ Build data downloaded - Querying failures of job/node-test-commit/41799/ ✔ Data downloaded ✖ 1 failure(s) on the last Jenkins CI run ℹ This PR was created on Thu, 29 Oct 2020 17:18:24 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35869#pullrequestreview-519999779 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/35869#pullrequestreview-520063736 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/35869#pullrequestreview-521123505 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/340140135 |
github-actions
bot
added
the
commit-queue-failed
watilde
removed
the
commit-queue-failed
watilde
added a commit
that referenced
this pull request
Nov 1, 2020
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: #35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
watilde
added a commit
that referenced
this pull request
Nov 1, 2020
Refs: web-platform-tests/wpt#9361 PR-URL: #35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
Landed in 5735525...2351e2c |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: #35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Refs: web-platform-tests/wpt#9361 PR-URL: #35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 24, 2021
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: nodejs#35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 24, 2021
Refs: web-platform-tests/wpt#9361 PR-URL: nodejs#35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 26, 2021
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: nodejs#35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 26, 2021
Refs: web-platform-tests/wpt#9361 PR-URL: nodejs#35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: nodejs#35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
Refs: web-platform-tests/wpt#9361 PR-URL: nodejs#35869 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2021
The AbortController abort event should have EventTarget as a target property of the argument event. PR-URL: #35869 Backport-PR-URL: #38386 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2021
Refs: web-platform-tests/wpt#9361 PR-URL: #35869 Backport-PR-URL: #38386 Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate abort_controller's test cases from the WPT and fixed
event.targethandling based on failure cases of WPT's test result.Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes