fix: zlib inlining failed fix for IA-32 #35679
Conversation
|
Welcome, @RaisinTen, and thanks for the pull request! If possible, we'll want to avoid floating an additional patch on a dependency like this, especially for unsupported platforms. I think it would be better to first get #33044 land-able, and then perhaps update zlib.h per doc/guides/maintaining-zlib.md. I don't know if that will fix your issue or not, but regardless, I think we want to do that before patching a dependency like this. |
|
Hello @Trott. 🙂 Going through the PR, I understand that we are going to update the zlib-chromium fork regularly. In that case, my change, which is basically a change to the zlib files would end up getting erased on updates. So, I should add my change to |
|
@nodejs/zlib Thoughts on this? I guess we can land this and then it will be over-written if #33044 ever lands. But there's a danger that will be stalled for a long time. |
github-actions
bot
removed
the
request-ci
|
Hey @Trott, do you know when we can land this PR? It's taking a long time, so I was wondering. |
Trott
force-pushed
the
zlib-inlining-error-fix
branch
from
201189c
to
ab587ca
Compare
|
Landed in ab587ca. |
PR-URL: #35679 Fixes: #35629 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #35679 Fixes: #35629 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #35679 Fixes: #35629 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #35679 Fixes: #35629 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#35679 Fixes: nodejs#35629 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
closes:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes