[v14.x] Revert "tools: add missing uv_setup_argv() calls" #35641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.
|
Review requested:
|
nodejs-github-bot
added
tools
4 tasks
|
Looks like it is this commit as /cc @richardlau @addaleax |
|
I think reverting this on v14.x only is fine as long as it passes CI :) |
richardlau
approved these changes
Oct 14, 2020
BethGriggs
added a commit
that referenced
this pull request
Oct 14, 2020
This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e. Refs: #35491 PR-URL: #35641 Reviewed-By: Richard Lau <[email protected]>
|
Landed in bd34410 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-asanis failing onv14.x. I suspect it is due to this commit - I'm raising this PR to initially just test whether this commit is the cause of the failure (I'm having trouble runningtest-asanlocally).The original PR passed
test-asan, so I suspect if this commit is the cause, it would be due to a related commit missing on v14.x.This reverts commit 70e77f123164ecbdbdd4abc2e4919ce1b193421e.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes