Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check for AbortController existence #35616

Closed
wants to merge 2 commits into from
Closed

test: check for AbortController existence #35616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fa6e3a
test: check for AbortController existence
jasnell Oct 12, 2020
9413138
[Squash] add suggested comment
jasnell Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ function platformTimeout(ms) {
}

let knownGlobals = [
AbortController,
clearImmediate,
clearInterval,
clearTimeout,
Expand All @@ -264,6 +263,15 @@ let knownGlobals = [
queueMicrotask,
];

// TODO(@jasnell): This check can be temporary. AbortController is
// not currently supported in either Node.js 12 or 10, making it
// difficult to run tests comparitively on those versions. Once
// all supported versions have AbortController as a global, this
// check can be removed and AbortController can be added to the
// knownGlobals list above.
if (global.AbortController)
jasnell marked this conversation as resolved.
Show resolved Hide resolved
knownGlobals.push(global.AbortController);

if (global.gc) {
knownGlobals.push(global.gc);
}
Expand Down