-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: importModuleDynamically
receives a Script
, not Module
#35593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
vm
Issues and PRs related to the vm subsystem.
labels
Oct 11, 2020
SimenB
commented
Oct 11, 2020
@nodejs/vm @nodejs/modules-active-members |
devsnek
suggested changes
Oct 12, 2020
@nodejs/modules |
devsnek
approved these changes
Oct 16, 2020
Trott
approved these changes
Oct 16, 2020
benjamingr
approved these changes
Oct 16, 2020
MylesBorins
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 16, 2020
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 16, 2020
Commit Queue failed- Loading data for nodejs/node/pull/35593 ✔ Done loading data for nodejs/node/pull/35593 ----------------------------------- PR info ------------------------------------ Title docs: `importModuleDynamically` receives a `Script`, not `Module` (#35593) Author Simen Bekkhus (@SimenB) Branch SimenB:patch-1 -> nodejs:master Labels doc, vm Commits 5 - docs: `importModuleDynamically` receives a `Script`, not `Module` - Update vm.md - Revert "Update vm.md" - update type-parser.js - `SourceTextModule` gets a `Module` Committers 2 - GitHub - Simen Bekkhus PR-URL: https://github.com/nodejs/node/pull/35593 Reviewed-By: Gus Caplan Reviewed-By: Rich Trott Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35593 Reviewed-By: Gus Caplan Reviewed-By: Rich Trott Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected ℹ This PR was created on Sun, 11 Oct 2020 11:54:09 GMT ✔ Approvals: 3 ✔ - Gus Caplan (@devsnek): https://github.com/nodejs/node/pull/35593#pullrequestreview-510094542 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35593#pullrequestreview-510118512 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/35593#pullrequestreview-510186834 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/310873129 |
github-actions
bot
added
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Oct 16, 2020
PR-URL: nodejs#35593 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Landed in ee85eb9 |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #35593 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35593 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesMatches what I see at runtime and what the tests assert:
node/test/parallel/test-vm-module-dynamic-import.js
Line 37 in 900f28a
As an aside - receiving an object/instance of something that can be inspected would be useful - specifically getting a reference to the
vm.Context
object the script is executed with. Also itsfilename
. But that's probably something for a feature request?