Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: importModuleDynamically receives a Script, not Module #35593

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 11, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Matches what I see at runtime and what the tests assert:

assert.strictEqual(wrap, s);

As an aside - receiving an object/instance of something that can be inspected would be useful - specifically getting a reference to the vm.Context object the script is executed with. Also its filename. But that's probably something for a feature request?

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Oct 11, 2020
doc/api/vm.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Oct 12, 2020

@nodejs/vm @nodejs/modules-active-members

doc/api/vm.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Oct 16, 2020

@nodejs/modules

@MylesBorins MylesBorins added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 16, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 16, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/35593
✔  Done loading data for nodejs/node/pull/35593
----------------------------------- PR info ------------------------------------
Title      docs: `importModuleDynamically` receives a `Script`, not `Module` (#35593)
Author     Simen Bekkhus  (@SimenB)
Branch     SimenB:patch-1 -> nodejs:master
Labels     doc, vm
Commits    5
 - docs: `importModuleDynamically` receives a `Script`, not `Module`
 - Update vm.md
 - Revert "Update vm.md"
 - update type-parser.js
 - `SourceTextModule` gets a `Module`
Committers 2
 - GitHub 
 - Simen Bekkhus 
PR-URL: https://github.com/nodejs/node/pull/35593
Reviewed-By: Gus Caplan 
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35593
Reviewed-By: Gus Caplan 
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
   ℹ  This PR was created on Sun, 11 Oct 2020 11:54:09 GMT
   ✔  Approvals: 3
   ✔  - Gus Caplan (@devsnek): https://github.com/nodejs/node/pull/35593#pullrequestreview-510094542
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35593#pullrequestreview-510118512
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/35593#pullrequestreview-510186834
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/310873129

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 16, 2020
PR-URL: nodejs#35593
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 18, 2020

Landed in ee85eb9

@Trott Trott merged commit ee85eb9 into nodejs:master Oct 18, 2020
@SimenB SimenB deleted the patch-1 branch October 18, 2020 08:54
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
PR-URL: #35593
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35593
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants