-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use sentence case for class property #35540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
tools
Issues and PRs related to the tools directory.
labels
Oct 7, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 7, 2020
lpinca
approved these changes
Oct 7, 2020
addaleax
approved these changes
Oct 7, 2020
Change the one instance of the Class Property heading in our docs to Class property to match style with other headers. PR-URL: nodejs#35540 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Landed in 936ce85 |
BethGriggs
pushed a commit
that referenced
this pull request
Oct 14, 2020
Change the one instance of the Class Property heading in our docs to Class property to match style with other headers. PR-URL: #35540 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
Change the one instance of the Class Property heading in our docs to Class property to match style with other headers. PR-URL: #35540 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
Change the one instance of the Class Property heading in our docs to Class property to match style with other headers. PR-URL: #35540 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Change the one instance of the Class Property heading in our docs to Class property to match style with other headers. PR-URL: nodejs#35540 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes