[v10.x] n-api: create N-API version 7 #35336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: nodejs#35199 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhof
requested review from
richardlau,
legendecas and
lundibundi
|
Review requested:
|
nodejs-github-bot
added
the
c++
4 tasks
gengjiawen
approved these changes
Sep 25, 2020
lundibundi
approved these changes
Sep 25, 2020
| @@ -34,7 +34,7 @@ assert.notStrictEqual(test_general.testGetPrototype(baseObject), | |||
|
|
|||
| // test version management functions | |||
| // expected version is currently 4 | |||
| assert.strictEqual(test_general.testGetVersion(), 6); | |||
| assert.strictEqual(test_general.testGetVersion(), 7); | |||
There was a problem hiding this comment.
I think the comment above should've also been changed but since this is a backport it's fine like this.
richardlau
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
@gabrielschulhof Should this update the N-API version matrix table?
github-actions
bot
removed
the
request-ci
|
@richardlau looks like we missed updating the matrix in master, opened #35345 to discuss how we might do that. Given that we don't know the versions in advance, I think we've deferred backporting the matrix |
richardlau
pushed a commit
that referenced
this pull request
Oct 7, 2020
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #35199 Backport-PR-URL: #35336 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 54c2bc2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
napi_detach_arraybufferandnapi_is_detached_arraybufferasstable.
Signed-off-by: @gabrielschulhof
PR-URL: #35199
Reviewed-By: @cjihrig
Reviewed-By: @gengjiawen
Reviewed-By: @legendecas
Reviewed-By: @mhdawson
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes