Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update my email address #35121

Closed
wants to merge 1 commit into from
Closed

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Sep 9, 2020

Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 9, 2020
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson If you're also planning to configure git to use your updated email address consider updating the .mailmap as well.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 9, 2020

@richardlau for commits I'm just going to use [email protected] so if anything I'll remove the ibm email once I no longer have access to it.

@richardlau
Copy link
Member

@richardlau for commits I'm just going to use [email protected] so if anything I'll remove the ibm email once I no longer have access to it.

I'd leave the entry in the mailmap so it continues to map your authorship of previous commits.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 9, 2020

@richardlau, k will leave as is

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2020
@nodejs-github-bot
Copy link
Collaborator

mhdawson added a commit that referenced this pull request Sep 11, 2020
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@mhdawson
Copy link
Member Author

Landed in 91272bc

@mhdawson mhdawson closed this Sep 11, 2020
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants