Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to uvwasi 0.0.11 #35104

Closed
wants to merge 1 commit into from
Closed

deps: update to uvwasi 0.0.11 #35104

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 8, 2020

Notable changes:

  • Several issues have been addressed in uvwasi_fd_readdir().
    A bug in the copying of the directory entry's name has been fixed.
    The function now returns UVWASI_ENOSYS on Windows and Android.
    Serdes support has been added for uvwasi_dirent_t's.
  • The libuv dependency has been updated to v1.39.0 (not relevant for the Node.js integration).
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Notable changes:

- Several issues have been addressed in uvwasi_fd_readdir().
  A bug in the copying of the directory entry's name has been fixed.
  The function now returns UVWASI_ENOSYS on Windows and Android.
  Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added the wasi Issues and PRs related to the WebAssembly System Interface. label Sep 8, 2020
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@gengjiawen
Copy link
Member

@mmarchini CodeOwner looks like not working. Is this because wasi team should have write permission for
nodejs/node repo ?

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 9, 2020

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 9, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Sep 11, 2020
Notable changes:

- Several issues have been addressed in uvwasi_fd_readdir().
  A bug in the copying of the directory entry's name has been fixed.
  The function now returns UVWASI_ENOSYS on Windows and Android.
  Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.

PR-URL: nodejs#35104
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 11, 2020

Landed in 636c0bb

@Trott Trott closed this Sep 11, 2020
@cjihrig cjihrig deleted the uvwasi branch September 11, 2020 13:43
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
Notable changes:

- Several issues have been addressed in uvwasi_fd_readdir().
  A bug in the copying of the directory entry's name has been fixed.
  The function now returns UVWASI_ENOSYS on Windows and Android.
  Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.

PR-URL: #35104
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
4 tasks
ruyadorno added a commit that referenced this pull request Sep 21, 2020
Notable changes:

- deps:
  - update to uvwasi 0.0.11 (Colin Ihrig)
  [#35104](#35104)
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
  [#35199](#35199)
  - add more property defaults (Gerhard Stoebich)
  [#35214](#35214)

PR-URL: #35285
ruyadorno added a commit that referenced this pull request Sep 22, 2020
Notable changes:

- deps:
  - update to uvwasi 0.0.11 (Colin Ihrig)
  [#35104](#35104)
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
  [#35199](#35199)
  - add more property defaults (Gerhard Stoebich)
  [#35214](#35214)

PR-URL: #35285
ruyadorno added a commit that referenced this pull request Sep 22, 2020
Notable changes:

- deps:
  - update to uvwasi 0.0.11 (Colin Ihrig)
  [#35104](#35104)
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
  [#35199](#35199)
  - add more property defaults (Gerhard Stoebich)
  [#35214](#35214)

PR-URL: #35285
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
Notable changes:

- Several issues have been addressed in uvwasi_fd_readdir().
  A bug in the copying of the directory entry's name has been fixed.
  The function now returns UVWASI_ENOSYS on Windows and Android.
  Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.

PR-URL: #35104
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
Notable changes:

- Several issues have been addressed in uvwasi_fd_readdir().
  A bug in the copying of the directory entry's name has been fixed.
  The function now returns UVWASI_ENOSYS on Windows and Android.
  Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.

PR-URL: #35104
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Notable changes:

- Several issues have been addressed in uvwasi_fd_readdir().
  A bug in the copying of the directory entry's name has been fixed.
  The function now returns UVWASI_ENOSYS on Windows and Android.
  Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.

PR-URL: nodejs#35104
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Notable changes:

- deps:
  - update to uvwasi 0.0.11 (Colin Ihrig)
  [nodejs#35104](nodejs#35104)
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
  [nodejs#35199](nodejs#35199)
  - add more property defaults (Gerhard Stoebich)
  [nodejs#35214](nodejs#35214)

PR-URL: nodejs#35285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants