test: improve tests for util.inherits #3507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inherits is used in lib and tests but its functionality itself is not tested yet.
|
|
|
Good point, done! |
| assert.throws(function() { util.inherits(ctor, {}); }, TypeError); | ||
| assert.throws(function() { util.inherits(ctor, null); }, TypeError); | ||
| assert.throws(function() { util.inherits(null, ctor); }, TypeError); | ||
| assert.doesNotThrow(function() { util.inherits(ctor, ctor); }, TypeError); |
There was a problem hiding this comment.
I think this is removed in favour of #3455?
There was a problem hiding this comment.
Not really. I think this line was added to make sure inherits doesn't throw when two constructors are passed to it. Now it is implicitly tested with this PR.
|
LGTM |
targos
added a commit
that referenced
this pull request
Oct 26, 2015
inherits is used in lib and tests but its functionality itself is not tested yet. PR-URL: #3507 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
Thanks, landed in df738ac. |
targos
added a commit
that referenced
this pull request
Oct 26, 2015
inherits is used in lib and tests but its functionality itself is not tested yet. PR-URL: #3507 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
@jasnell I think this can go in v4.x |
targos
added a commit
that referenced
this pull request
Oct 28, 2015
inherits is used in lib and tests but its functionality itself is not tested yet. PR-URL: #3507 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
Landed in v4.x-staging in 12d8385 |
targos
added a commit
that referenced
this pull request
Oct 29, 2015
inherits is used in lib and tests but its functionality itself is not tested yet. PR-URL: #3507 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Apr 29, 2023
This was referenced Jun 22, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inherits is used in lib and tests but its functionality itself is not
tested yet.
This is preparation for PR #3455 so I can add more tests to it.