-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix doc build targets #35060
tools: fix doc build targets #35060
Conversation
I just applied this patch to my fork and here's the error:
|
@DerekNonGeneric Bummer, I don't have this error (I'm using GNU Make 3.81 built for i386-apple-darwin11.3.0, I suspect there are small differences with your version). |
I'm still missing the |
Adds doc output directory as order-only prerequisite for build target.
292458c
to
1e05cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#35060 (comment) resolved by #34986 (comment), so everything seems to be working as expected now.
This will need to land before #34986 otherwise doc workflow will be broken on master branch.
Adds doc output directory as order-only prerequisite for build target. PR-URL: #35060 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Landed in 8ae2f47 |
Adds doc output directory as order-only prerequisite for build target. PR-URL: #35060 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Adds doc output directory as order-only prerequisite for build target. PR-URL: #35060 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Adds doc output directory as order-only prerequisite for build target. PR-URL: #35060 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Adds doc output directory as order-only prerequisite for build target. PR-URL: #35060 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Adds doc output directory as order-only prerequisite for build target. PR-URL: nodejs#35060 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Adds doc output directory as order-only prerequisite for build target.
Currently, here is the issue:
The problem is that the
out/doc/api
directory is not created before trying to generate the files, which fails. This PR adds the directories as prerequisites to ensure the files can be generated.Repported by @DerekNonGeneric in #34986 (comment).
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes