Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix unit of size argument of readable.read #35051

Closed
wants to merge 1 commit into from
Closed

doc: fix unit of size argument of readable.read #35051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ buffer will be returned.
If the `size` argument is not specified, all of the data contained in the
internal buffer will be returned.

The `size` argument must be less than or equal to 1 GB.
The `size` argument must be less than or equal to 1 GiB.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, as if anyone has any great ideas, they can always be implemented later, but I think the distinction is esoteric enough that we should spell it out on the first occurrence (or maybe even every occurrence). But I'm also having a hard time figuring out a way to do it in a straightforward way. 1024^3 bytes is not exactly immediately clarifying. (My thought would be, "Isn't that the same as a GB?")


The `readable.read()` method should only be called on `Readable` streams
operating in paused mode. In flowing mode, `readable.read()` is called
Expand Down