Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add example for test structure #35046

Closed
wants to merge 1 commit into from

Conversation

wjabbour
Copy link
Contributor

@wjabbour wjabbour commented Sep 4, 2020

  • documentation is changed or added
  • commit message follows [commit guidelines]

each part of the example was copy/pasted and talked about in detail, i matched the convention of also showing the example being detailed

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 4, 2020
@wjabbour
Copy link
Contributor Author

@Trott
Hi, what do you think about this PR?

@Trott
Copy link
Member

Trott commented Sep 14, 2020

@Trott
Hi, what do you think about this PR?

No strong opinion. On the one hand, sure, it makes the treatment of the sections consistent. On the other hand, the other segments are much shorter and that could be considered a good reason for including them but not this longer one. So, on balance, I could go either way. Let's ping a few others. @nodejs/testing

@Lxxyx
Copy link
Member

Lxxyx commented Jan 30, 2021

I think it's great to keep it consistent.

@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2021
Lxxyx pushed a commit that referenced this pull request Feb 1, 2021
PR-URL: #35046
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@Lxxyx
Copy link
Member

Lxxyx commented Feb 1, 2021

Landed in c746c40 🎉

@Lxxyx Lxxyx closed this Feb 1, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #35046
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #35046
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants