-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove style for empty links #35034
Conversation
/cc @Trott as you are the one who suggested this. |
I imagine this may not be an issue now that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dear the anti-pattern exists elsewhere. For the error codes I think we can use a regular expression for if the heading starts with ERR
, but in the meantime, you're right about needing this to be corrected.
d543696
to
ec5958f
Compare
Landed in ec5958f |
PR-URL: nodejs#35034 Refs: nodejs#34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
PR-URL: #35034 Refs: #34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
PR-URL: nodejs#35034 Refs: nodejs#34955 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Fix the side effect when hovering over empty anchor links:
It appears on a few pages:
deprecations.htmlEDIT: Taken care of in doc: properly mark up deprecation anchors #34955Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesRefs: #34955