Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove style for empty links #35034

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 3, 2020

Fix the side effect when hovering over empty anchor links:

screenshot

It appears on a few pages:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refs: #34955

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 3, 2020
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 4, 2020

/cc @Trott as you are the one who suggested this.

@Trott
Copy link
Member

Trott commented Sep 4, 2020

I imagine this may not be an issue now that the <a name="DEPxxxx"></a> links are removed, but not a bad idea to do it anyway.

Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear the anti-pattern exists elsewhere. For the error codes I think we can use a regular expression for if the heading starts with ERR, but in the meantime, you're right about needing this to be corrected.

@Trott
Copy link
Member

Trott commented Sep 5, 2020

Landed in ec5958f

PR-URL: nodejs#35034
Refs: nodejs#34955
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@Trott Trott merged commit ec5958f into nodejs:master Sep 5, 2020
@aduh95 aduh95 deleted the fix-doc-empty-links branch September 5, 2020 22:06
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@richardlau richardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 8, 2020

Alas, this causes visited links to show in a different color.

image

Revert since we're eliminating <a name="foo"></a> tags anyway? Or add a:visited to the stylesheet?

@nodejs/website

@Trott
Copy link
Member

Trott commented Sep 8, 2020

#35108

addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35034
Refs: nodejs#34955
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants