Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix malformed hashes in assert.md #35028

Merged
merged 1 commit into from
Sep 5, 2020
Merged

doc: fix malformed hashes in assert.md #35028

merged 1 commit into from
Sep 5, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 3, 2020

URL hashes cannot contain #. Use hashes for the locations that were
intended.

Checklist

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Sep 3, 2020
@Trott
Copy link
Member Author

Trott commented Sep 4, 2020

@nodejs/website

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2020
@Trott Trott force-pushed the hash-fix branch 2 times, most recently from 994f269 to 16d058d Compare September 5, 2020 13:50
@Trott Trott merged commit 16d058d into nodejs:master Sep 5, 2020
@Trott
Copy link
Member Author

Trott commented Sep 5, 2020

Landed in 16d058d

@Trott Trott deleted the hash-fix branch September 5, 2020 13:50
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: nodejs#35028
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@richardlau richardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: nodejs#35028
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants