quic: fix error message on invalid connection ID #35026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v12.x
quic
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
gengjiawen
approved these changes
Sep 3, 2020
lpinca
approved these changes
Sep 3, 2020
MrHeer
approved these changes
Sep 3, 2020
|
Landed in 1862305 |
If Buffer.from() throws, it does not return a value, so the error message is always going to report `undefined`. Use the value passed to Buffer.from() instead. PR-URL: nodejs#35026 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
4 tasks
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
If Buffer.from() throws, it does not return a value, so the error message is always going to report `undefined`. Use the value passed to Buffer.from() instead. PR-URL: nodejs#35026 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Buffer.from() throws, it does not return a value, so the error
message is always going to report
undefined. Use the value passed toBuffer.from() instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes