Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken link to writableEnded in deprecations doc #34984

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 30, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Aug 30, 2020
@@ -2860,7 +2860,7 @@ The [`crypto.Certificate()` constructor][] is deprecated. Use
[`response.end()`]: http.html#http_response_end_data_encoding_callback
[`response.finished`]: #http_response_finished
[`response.writableFinished`]: #http_response_writablefinished
[`response.writableEnded`]: #http_response_writableended
[`response.writableEnded`]: http.html#http_response_writableended
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the two lines above also need fixing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau There are 2 other PRs which are doing the same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott isn't it better to use a single PR and commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For easing backport-ability, I often try to keep doc changes isolated in separate commits. (Then if a commit doesn't apply cleanly, it's either trivial to fix or else shouldn't be backported at all.) But yeah, these probably at least should have gone in a single PR. I'll try to batch things up a bit better in the future.

@Trott
Copy link
Member Author

Trott commented Sep 1, 2020

Landed in 772a21c

@Trott Trott merged commit 772a21c into nodejs:master Sep 1, 2020
@Trott Trott deleted the writable-ended branch September 1, 2020 14:38
richardlau pushed a commit that referenced this pull request Sep 1, 2020
PR-URL: #34984
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request Sep 2, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 3, 2020
PR-URL: #34984
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34984
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34984
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants