Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-tls-reuse-host-from-socket pass without internet #34953

Merged
merged 1 commit into from
Aug 30, 2020
Merged

test: make test-tls-reuse-host-from-socket pass without internet #34953

merged 1 commit into from
Aug 30, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 28, 2020

Start up a TLS server on localhost rather than using example.org.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 28, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 28, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32966/ ✅

@Trott
test: make test-tls-reuse-host-from-socket pass without internet
4fa439c 
Start up a TLS server on localhost rather than using example.org.

PR-URL: nodejs#34953
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott merged commit 4fa439c into nodejs:master Aug 30, 2020
@Trott
Copy link
Member Author

Trott commented Aug 30, 2020

Landed in 4fa439c

@Trott Trott deleted the internet-tls branch August 30, 2020 05:42
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@Trott @richardlau
test: make test-tls-reuse-host-from-socket pass without internet
75d1612 
Start up a TLS server on localhost rather than using example.org.

PR-URL: #34953
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: make test-tls-reuse-host-from-socket pass without internet
e19e195 
Start up a TLS server on localhost rather than using example.org.

PR-URL: #34953
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: make test-tls-reuse-host-from-socket pass without internet
46f94f9 
Start up a TLS server on localhost rather than using example.org.

PR-URL: #34953
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @addaleax @benjamingr @lpinca