[14.x] meta: remove non-existent quic from CODEOWNERS #34947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic support doesn't exist prior to Node.js 15 and is unlikely to due to requiring patches on top of openssl. Remove the entries from CODEOWNERS to fix the CODEOWNERS linting, which currently fails as it refers to non-existent paths.
|
Review requested:
|
nodejs-github-bot
added
the
meta
BethGriggs
approved these changes
Aug 27, 2020
gengjiawen
approved these changes
Aug 27, 2020
codebytere
approved these changes
Aug 27, 2020
mmarchini
approved these changes
Aug 31, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Aug 31, 2020
quic support doesn't exist prior to Node.js 15 and is unlikely to due to requiring patches on top of openssl. Remove the entries from CODEOWNERS to fix the CODEOWNERS linting, which currently fails as it refers to non-existent paths. PR-URL: #34947 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in a43b7ff |
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
quic support doesn't exist prior to Node.js 15 and is unlikely to due to requiring patches on top of openssl. Remove the entries from CODEOWNERS to fix the CODEOWNERS linting, which currently fails as it refers to non-existent paths. PR-URL: #34947 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
|
We haven't landed any of the CODEOWNERS stuff on v10.x so removing the watch label for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quic support doesn't exist prior to Node.js 15 and is unlikely to
due to requiring patches on top of openssl. Remove the entries
from CODEOWNERS to fix the CODEOWNERS linting, which currently fails
as it refers to non-existent paths.
@nodejs/releasers on its own this isn't worth holding up v14.9.0 for, you
can just ignore the CODEOWNERS lint action failure for now.
Checklist