Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: validate custom lookup() output #34813

Closed
wants to merge 1 commit into from
Closed

net: validate custom lookup() output #34813

wants to merge 1 commit into from
+14 −0

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 17, 2020 •
edited
Loading

This commit adds validation to the IP address returned by the
net module's custom DNS lookup() function.

Fixes: #34812

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig cjihrig requested a review from a team as a code owner August 17, 2020 19:02
@cjihrig cjihrig requested a review from a team August 17, 2020 19:02
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Aug 17, 2020
addaleax
addaleax approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this testable? :)

@jasnell
Copy link
Member

jasnell commented Aug 17, 2020

@addaleax:

Is this testable?

Yeah, see @cjihrig's comment in the original post:

I'll add a test later tonight when I have more time.

The current failure is an assertion failure, so a simple test that ensures that an error event occurs rather than a crash should be sufficient. A basic test case is already provided in the original issue.

@cjihrig
net: validate custom lookup() output
2b8851c 
This commit adds validation to the IP address returned by the
net module's custom DNS lookup() function.
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 18, 2020

Is this testable? :)

Test added!

mcollina
mcollina approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2020
@github-actions github-actions bot mentioned this pull request Aug 19, 2020
Open
7 tasks
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 19, 2020

Passing CI: https://ci.nodejs.org/job/node-test-pull-request/32845/

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2020
@jasnell jasnell mentioned this pull request Aug 19, 2020
Closed
3 tasks
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 19, 2020
@jasnell
Copy link
Member

jasnell commented Aug 19, 2020

Fast track? please 👍🏻

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2020
@github-actions
Copy link
Contributor

Landed in 24cc4a6

@github-actions github-actions bot closed this Aug 19, 2020
nodejs-github-bot pushed a commit that referenced this pull request Aug 19, 2020
@cjihrig @nodejs-github-bot
net: validate custom lookup() output
24cc4a6 
This commit adds validation to the IP address returned by the
net module's custom DNS lookup() function.

PR-URL: #34813
Fixes: #34812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig cjihrig deleted the ip branch August 19, 2020 19:26
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@cjihrig @addaleax
net: validate custom lookup() output
81af924 
This commit adds validation to the IP address returned by the
net module's custom DNS lookup() function.

PR-URL: #34813
Fixes: #34812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@cjihrig @addaleax
net: validate custom lookup() output
6b5d679 
This commit adds validation to the IP address returned by the
net module's custom DNS lookup() function.

PR-URL: #34813
Fixes: #34812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
This was referenced May 27, 2022
Open
Open
@137717unity 137717unity mentioned this pull request May 27, 2022
Open
@baby636 baby636 mentioned this pull request May 27, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request May 27, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 27, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@rickyes rickyes rickyes approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coredump when passing undefined as address from custom lookup function
10 participants
@cjihrig @nodejs-github-bot @jasnell @mcollina @addaleax @lpinca @targos @richardlau @rickyes @ZYSzys