-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v12.x backport] deps: V8: cherry-pick eec10a2fd8fa and #34008 #34776
[v12.x backport] deps: V8: cherry-pick eec10a2fd8fa and #34008 #34776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming we can verify the source of the test issue, as Myles suggests.
started my first debug session on a Mac :o)
|
I did an experiment and added the commits from this PR on top of 12.18.1. gulp and glob-watcher tests are green then. So I still don't know the root cause of the failures introduced in 12.18.2 but the changes from this PR seems to be ok. |
The fsevents version (1.2.13) used by glob-watcher users a |
This comment has been minimized.
This comment has been minimized.
Did some more investigations. Looks like the problem is a missing initialization of this uv_async_t as this may result in this check to return If I add |
The correct thing to do would be to not use the |
Is this ready to land? How does it differ from what we landed on master / v14.x? |
@MylesBorins It's really just a very small difference in the the patch contents. Functionally they are identical. Master: https://github.com/nodejs/node/pull/33778/files#diff-d047841e5be2101da57516c10fabb17c V8 changed to use |
Yes, it's more or less the same as on master/v14. Backport PR was needed because the patch didn't land clean. I think it's ready to land. |
@nodejs/lts Any chance that this gets included into the next v12 release? According to nodejs/Release#494 12.19.0 should be out soon. |
729799d
to
c9bd1a7
Compare
ab727f2
to
cb58cdb
Compare
be41c83
to
efb5192
Compare
This comment has been minimized.
This comment has been minimized.
55fe022
to
65b7bf4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
looks like V8 CI also failed on this one |
Infra blip. V8-CI rerun: https://ci.nodejs.org/job/node-test-commit-v8-linux/3396/ |
Or maybe not, looks like the job has merge issues checking out this PR. |
I will do a rebase and retry in couple of minutes |
cb58cdb
to
8befd11
Compare
This comment has been minimized.
This comment has been minimized.
v8 CI still fails because a lot files I haven't even touched require a merge according to git.... |
/cc @nodejs/build any idea what's going on with V8 CI? |
For some reason testing this PR was leaving the workspaces in an umerged state that was preventing the checkouts on subsequent jobs from succeeding. I've wiped out the workspaces and restarted the job. |
This comment has been minimized.
This comment has been minimized.
Original commit message: [promisehook] Add before/after hooks to thenable tasks This will allow Node.js to properly track async context in thenables. Change-Id: If441423789a78307a57ad7e645daabf551cddb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624 Reviewed-by: Camillo Bruni <[email protected]> Reviewed-by: Sathya Gunasekaran <[email protected]> Commit-Queue: Gus Caplan <[email protected]> Cr-Commit-Position: refs/heads/master@{#68207} Refs: v8/v8@eec10a2 PR-URL: nodejs#33778 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This adds a test to verify that AsyncLocalStorage works with thenables. PR-URL: nodejs#34008 Refs: nodejs#33778 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
8befd11
to
227a637
Compare
rebased once more as there was a conflict. CI is green now 🎉 |
Original commit message: [promisehook] Add before/after hooks to thenable tasks This will allow Node.js to properly track async context in thenables. Change-Id: If441423789a78307a57ad7e645daabf551cddb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624 Reviewed-by: Camillo Bruni <[email protected]> Reviewed-by: Sathya Gunasekaran <[email protected]> Commit-Queue: Gus Caplan <[email protected]> Cr-Commit-Position: refs/heads/master@{#68207} Refs: v8/v8@eec10a2 Backport-PR-URL: #34776 PR-URL: #33778 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This adds a test to verify that AsyncLocalStorage works with thenables. Backport-PR-URL: #34776 PR-URL: #34008 Refs: #33778 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in b7e4d5f...232f6e1 :) |
Backport #33778 and #34008 to v12.
There was already a backport PR (#34300) for #33778 but it was removed during creation of 12.18.3 as it looked like it breaks gulp tests on MacOs.
Later it turned out that gulp tests were broken already before therefore I see no reason anymore to not backport this to v12.
In this backport PR I added additionally #34008 which is just a new test to verify the backported fix.
see comments at #33778 (comment)
fyi @Qard, @MylesBorins
Refs: #33778
Refs: #34008
Refs: #34300
Refs: #34343