-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: reduce repetitiveness on Consensus Seeking #34702
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearrange Consensus Seeking section to reduce repetitiveness. Ref: nodejs#34639 (comment) Ref: nodejs#34639 (comment)
4 tasks
jasnell
approved these changes
Aug 10, 2020
jvmazagao
approved these changes
Aug 10, 2020
guybedford
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect to me!
lpinca
approved these changes
Aug 10, 2020
Landed in 2f27f11 |
mmarchini
added a commit
that referenced
this pull request
Aug 12, 2020
Rearrange Consensus Seeking section to reduce repetitiveness. Ref: #34639 (comment) Ref: #34639 (comment) PR-URL: #34702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
Rearrange Consensus Seeking section to reduce repetitiveness. Ref: #34639 (comment) Ref: #34639 (comment) PR-URL: #34702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
Rearrange Consensus Seeking section to reduce repetitiveness. Ref: #34639 (comment) Ref: #34639 (comment) PR-URL: #34702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Rearrange Consensus Seeking section to reduce repetitiveness. Ref: #34639 (comment) Ref: #34639 (comment) PR-URL: #34702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Rearrange Consensus Seeking section to reduce repetitiveness. Ref: #34639 (comment) Ref: #34639 (comment) PR-URL: #34702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes