Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick e06ace6b5cdb #34673

Closed
wants to merge 3 commits into from
Closed

deps: V8: cherry-pick e06ace6b5cdb #34673

wants to merge 3 commits into from

Commits on Aug 7, 2020

  1. deps: V8: cherry-pick e06ace6b5cdb 

    Original commit message:

    [api] Fix empty Maybe crash in GetRealNamedPropertyAttributes

    `Object::GetRealNamedPropertyAttributes()` can crash if an empty
    `Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because
    it was not checking for that. Fix that.

    Refs: nodejs#34606
    Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057
    Commit-Queue: Leszek Swirski <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#69258}

Refs: v8/v8@e06ace6
    @addaleax
    addaleax committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    2b0a451 View commit details
    Browse the repository at this point in the history

  2. test: add vm crash regression test 

    Fixes: nodejs#34606
    @addaleax
    addaleax committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    bd0ccf2 View commit details
    Browse the repository at this point in the history

  3. fixup! test: add vm crash regression test

    @addaleax
    addaleax committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    37e4ec2 View commit details
    Browse the repository at this point in the history