src: set SA_SIGINFO flag when using sa_sigaction #34648
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
addaleax
reviewed
Aug 6, 2020
For `sigaction()` the `SA_SIGINFO` flag should be set when setting the handler via the `sa_sigaction` member of the `sigaction` struct.
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
jasnell
reviewed
Aug 6, 2020
Co-authored-by: James M Snell <[email protected]>
jasnell
approved these changes
Aug 6, 2020
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Aug 6, 2020
richardlau
added
author ready
This was referenced Aug 7, 2020
|
So I'm not sure why but it looks like on AIX if |
FWIW I've distilled the problem down to https://github.com/richardlau/signals |
This was referenced Aug 8, 2020
This was referenced Aug 12, 2020
fhinkel
approved these changes
Aug 24, 2020
github-actions
bot
removed
the
request-ci
|
This needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
sigaction()theSA_SIGINFOflag should be set when settingthe handler via the
sa_sigactionmember of thesigactionstruct.This unfortunately doesn't fix #34410 but AFAICT looks correct based
on the
sigaction()docs.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes