Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: use _Node.js_ in user-facing REPL text #34644

Closed
wants to merge 1 commit into from
Closed

repl: use _Node.js_ in user-facing REPL text #34644

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 6, 2020

We use node (REPL) in one place and Node.js (REPL) in another place
in error messages in repl.js. Use Node.js in both places.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Aug 6, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2020
@Trott Trott changed the title doc: use _Node.js_ in user-facing REPL text repl: use _Node.js_ in user-facing REPL text Aug 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32643/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 6, 2020
jasnell
jasnell approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-track? Trivial enough that it shouldn't need to wait

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2020
@Trott
repl: use _Node.js_ in user-facing REPL text
1019bc9 
We use _node (REPL)_ in one place and _Node.js (REPL)_ in another place
in error messages in repl.js. Use _Node.js_ in both places.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 8, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32687/ (:green_heart:)

@addaleax addaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label Aug 8, 2020
@addaleax
Copy link
Member

addaleax commented Aug 8, 2020

Landed in 989d82f

addaleax pushed a commit that referenced this pull request Aug 8, 2020
@Trott @addaleax
repl: use _Node.js_ in user-facing REPL text
989d82f 
We use _node (REPL)_ in one place and _Node.js (REPL)_ in another place
in error messages in repl.js. Use _Node.js_ in both places.

PR-URL: #34644
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax closed this Aug 8, 2020
addaleax pushed a commit that referenced this pull request Aug 8, 2020
@Trott @addaleax
repl: use _Node.js_ in user-facing REPL text
ddd339f 
We use _node (REPL)_ in one place and _Node.js (REPL)_ in another place
in error messages in repl.js. Use _Node.js_ in both places.

PR-URL: #34644
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@Trott @codebytere
repl: use _Node.js_ in user-facing REPL text
0c4226e 
We use _node (REPL)_ in one place and _Node.js (REPL)_ in another place
in error messages in repl.js. Use _Node.js_ in both places.

PR-URL: #34644
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott Trott deleted the nodejs-repl branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @addaleax @jasnell @lpinca @targos @trivikr