Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: increase startCI verbosity and fix job name #34635

Closed
wants to merge 1 commit into from
Closed

build: increase startCI verbosity and fix job name #34635

wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

Ref: #34594 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 5, 2020
@mmarchini
Copy link
Contributor Author

This will help us understand silent failures on the job. Fast track?

@mmarchini mmarchini added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 5, 2020
@mmarchini
Copy link
Contributor Author

Landed in e0d181c

@mmarchini mmarchini closed this Aug 5, 2020
mmarchini added a commit that referenced this pull request Aug 5, 2020
@mmarchini
build: increase startCI verbosity and fix job name
e0d181c 
Ref: #34594 (comment)

PR-URL: #34635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Aug 6, 2020
@mmarchini @codebytere
build: increase startCI verbosity and fix job name
10f29e7 
Ref: #34594 (comment)

PR-URL: #34635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@mmarchini @codebytere
build: increase startCI verbosity and fix job name
338994f 
Ref: #34594 (comment)

PR-URL: #34635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mmarchini @addaleax
build: increase startCI verbosity and fix job name
0e2a44f 
Ref: #34594 (comment)

PR-URL: #34635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mmarchini @addaleax
build: increase startCI verbosity and fix job name
90a44e1 
Ref: #34594 (comment)

PR-URL: #34635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmarchini @addaleax @gengjiawen @richardlau @nodejs-github-bot