Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: harden test-child-process-fork-regr-gh-2847 #3459

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

test-child-process-fork-regr-gh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur. This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

submitting on behalf of gireeshpunathil as he is out on
vacation this week. See discussion in #3245
in respect to detailed investigation of test behaviour

test-child-process-fork-regr-nodejsgh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur.  This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

submitting on behalf of gireeshpunathil as he is out on
vacation this week
@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. labels Oct 20, 2015
@jasnell
Copy link
Member

jasnell commented Oct 21, 2015

LGTM

@jasnell
Copy link
Member

jasnell commented Oct 21, 2015

@jasnell
Copy link
Member

jasnell commented Oct 21, 2015

@mhdawson ... there are some CI failures but they don't look relevant to this change. Can you take a look and verify?

@mhdawson
Copy link
Member Author

Agreed don't think any of those failures are related to this PR.

mhdawson added a commit that referenced this pull request Oct 21, 2015
test-child-process-fork-regr-gh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur.  This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

Reviewed-By: James M Snell <[email protected]>
PR-URL: #3459
@jasnell
Copy link
Member

jasnell commented Oct 21, 2015

Landed in e9e837c

@jasnell jasnell closed this Oct 21, 2015
mhdawson added a commit to ibmruntimes/node that referenced this pull request Oct 21, 2015
test-child-process-fork-regr-nodejsgh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur.  This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#3459
mhdawson added a commit that referenced this pull request Oct 22, 2015
test-child-process-fork-regr-gh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur.  This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

Reviewed-By: James M Snell <[email protected]>
PR-URL: #3459
@jbergstroem
Copy link
Member

@mhdawson for future reference, can you add fixes: $url to the commit message metadata if a bug is fixed with the commit? The added bonus is that the issue auto-closes when you merge it.

mhdawson added a commit that referenced this pull request Oct 26, 2015
test-child-process-fork-regr-gh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur.  This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

Reviewed-By: James M Snell <[email protected]>
PR-URL: #3459
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

Landed in v4.x-staging in 304eda4

mhdawson added a commit that referenced this pull request Oct 29, 2015
test-child-process-fork-regr-gh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur.  This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

Reviewed-By: James M Snell <[email protected]>
PR-URL: #3459
@mhdawson mhdawson deleted the 2847 branch March 15, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants