meta: enable http2 team for CODEOWNERS #34534
Conversation
nodejs-github-bot
added
the
meta
|
Do we want to keep adding teams as subteams of collaborators, or should we move forward with something like #34150 / nodejs/github-bot#265? I can get these PRs moving again this week if that's the path we want moving forward. |
I'd prefer to avoid the subteams thing, but I don't mind subteams as a temporary measure with what you're working on as the eventual goal. |
|
I just noticed our first "oops, we have someone with Collaborator privileges who is no longer a Collaborator due to the quic subteam" thing. (I've fixed it.) |
.github/CODEOWNERS
Outdated
| ./lib/http2.js @nodejs/http2 @nodejs/net | ||
| ./lib/internal/http2/* @nodejs/http2 @nodejs/net | ||
| ./src/node_http2* @nodejs/http2 @nodejs/net | ||
| ./src/node_mem* @nodejs/http2 |
There was a problem hiding this comment.
The only member of the net team who is not in the HTTP/2 team is @indutny, and the team is largely defunct anyway. Not trying to speak for him, but maybe it makes sense to just put @nodejs/http2 everywhere here?
|
Unblocked. Ready to land. |
|
Landed in a11aa9b |
PR-URL: #34534 Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #34534 Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #34534 Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #34534 Reviewed-By: Anna Henningsen <[email protected]>
This will require some http2 clean-up before landing. It will also require http2 and net becoming sub-teams of the collaborators team. So I'll mark it blocked for now, but it's ready for reviews.
Checklist