Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: use OpenSSL built-in cert and hostname validation #34533

Closed
wants to merge 1 commit into from
Closed

quic: use OpenSSL built-in cert and hostname validation #34533

wants to merge 1 commit into from
+21 −608

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 27, 2020

Use the built-in openssl hostname validation instead of the roll-our-own version.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnell jasnell requested a review from a team July 27, 2020 23:19
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 27, 2020
@jasnell jasnell added dont-land-on-v14.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 27, 2020 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32519/
QUIC CI: https://ci.nodejs.org/job/node-test-commit/39871/

@jasnell
Copy link
Member Author

jasnell commented Jul 28, 2020

Resume QUIC CI: https://ci.nodejs.org/job/node-test-commit/39872/

@jasnell jasnell mentioned this pull request Jul 28, 2020
Closed
4 tasks
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 28, 2020
jasnell added a commit that referenced this pull request Jul 31, 2020
@jasnell
quic: use OpenSSL built-in cert and hostname validation
a97b5f9 
PR-URL: #34533
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Jul 31, 2020

Landed in a97b5f9

@jasnell jasnell closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @nodejs-github-bot @addaleax