Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace flaky pummel regression tests #34530

Closed
wants to merge 2 commits into from

Commits on Jul 30, 2020

  1. test: replace flaky pummel regression tests

    These tests were written a long time ago, and use the allocation of
    large amounts of unused memory as a way to detect use-after-free
    problems with Buffers. As a result, the tests are resource-intensive
    and may crash because of that.
    
    Replace them with a more modern test. We don’t explicitly try to
    *detect* use-after-free conditions, and instead rely on e.g. ASAN
    (or the process just crashing hard) to do that for us.
    
    Fixes: nodejs#34527
    addaleax authored and Trott committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    475796a View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. fixup! test: replace flaky pummel regression tests

    Co-authored-by: Rich Trott <[email protected]>
    addaleax and Trott committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    08ec934 View commit details
    Browse the repository at this point in the history