Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] timers: allow timers to be used as primitives #34482

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] timers: allow timers to be used as primitives #34482

wants to merge 1 commit into from

Commits on Jul 22, 2020

  1. timers: allow timers to be used as primitives 

    This allows timers to be matched to numeric Ids and therefore used
as keys of an Object, passed and stored without storing the Timer instance.

clearTimeout/clearInterval is modified to support numeric/string Ids.

Co-authored-by: Bradley Farias <[email protected]>
Co-authored-by: Anatoli Papirovski <[email protected]>

Refs: nodejs#21152

PR-URL: nodejs#34017
Backport-PR-URL: nodejs#34482
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Signed-off-by: Denys Otrishko <[email protected]>
    @lundibundi
    lundibundi committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    9a4ab57 View commit details
    Browse the repository at this point in the history