-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: guard against nullptr deref in TimerWrapHandle::Stop #34460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
labels
Jul 21, 2020
4 tasks
gengjiawen
approved these changes
Jul 21, 2020
richardlau
approved these changes
Jul 21, 2020
jasnell
approved these changes
Jul 21, 2020
devnexen
approved these changes
Jul 21, 2020
CI: https://ci.nodejs.org/job/node-test-pull-request/32442/ (:green_heart:) |
jasnell
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jul 21, 2020
Fast-track? Please 👍🏻 |
Landed in feb93c4 |
addaleax
added a commit
that referenced
this pull request
Jul 21, 2020
Refs: #34454 PR-URL: #34460 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Refs: #34454 PR-URL: #34460 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
This does not land cleanly on v14.x 🤔 should it be backported ? |
targos
removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-requested-v14.x
labels
Apr 30, 2021
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: #34454 PR-URL: #34460 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
fast-track
PRs that do not need to wait for 48 hours to land.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #34454
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes