Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: guard against nullptr deref in TimerWrapHandle::Stop #34460

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #34454

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jul 21, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2020

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 21, 2020
@jasnell
Copy link
Member

jasnell commented Jul 21, 2020

Fast-track? Please 👍🏻

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 21, 2020
@addaleax
Copy link
Member Author

Landed in feb93c4

@addaleax addaleax closed this Jul 21, 2020
addaleax added a commit that referenced this pull request Jul 21, 2020
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@addaleax addaleax deleted the timer-wrap-nullptr-deref branch July 21, 2020 19:11
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@ruyadorno
Copy link
Member

This does not land cleanly on v14.x 🤔 should it be backported ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants