Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: match link text in index to doc headline #34449

Merged
merged 0 commits into from
Jul 23, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 20, 2020

The index ToC says "About these docs" but the document itself says
"About this documentation" which I think is better. Use that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 20, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 22, 2020
@Trott
Copy link
Member Author

Trott commented Jul 23, 2020

@nodejs/documentation

@Trott
Copy link
Member Author

Trott commented Jul 23, 2020

Landed in 69c78be

@Trott Trott closed this Jul 23, 2020
@Trott Trott merged commit 69c78be into nodejs:master Jul 23, 2020
@Trott Trott deleted the matchup branch July 23, 2020 13:39
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
The index ToC says "About these docs" but the document itself says
"About this documentation" which I think is better. Use that.

PR-URL: #34449
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The index ToC says "About these docs" but the document itself says
"About this documentation" which I think is better. Use that.

PR-URL: #34449
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The index ToC says "About these docs" but the document itself says
"About this documentation" which I think is better. Use that.

PR-URL: #34449
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants