Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add statement of purpose to documentation style guide #34424

Merged
merged 0 commits into from
Jul 21, 2020
Merged

doc: add statement of purpose to documentation style guide #34424

merged 0 commits into from
Jul 21, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 18, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 18, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 19, 2020
@Trott
Copy link
Member Author

Trott commented Jul 21, 2020

Landed in ebf2cd1

@Trott Trott closed this Jul 21, 2020
@Trott Trott merged commit ebf2cd1 into nodejs:master Jul 21, 2020
@Trott Trott deleted the style-guide branch July 21, 2020 01:15
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott @cjihrig
doc: add statement of purpose to documentation style guide
8443230 
PR-URL: #34424
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@Trott @MylesBorins
doc: add statement of purpose to documentation style guide
29ad6fb 
PR-URL: #34424
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: add statement of purpose to documentation style guide
077c477 
PR-URL: #34424
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: add statement of purpose to documentation style guide
8ee83a9 
PR-URL: #34424
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekNonGeneric DerekNonGeneric DerekNonGeneric left review comments

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @addaleax @lpinca @trivikr @DerekNonGeneric @nodejs-github-bot