Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/streams: don't return the stream object from onStreamRead #34375

Closed
wants to merge 10 commits into from
Closed

net/streams: don't return the stream object from onStreamRead #34375

wants to merge 10 commits into from

Commits on Jul 24, 2020

  1. streams: don't return the stream object from onStreamRead 

    CallJSOnreadMethod expects the return value to be undefined or
a new buffer, so make sure to return nothing, even when an error
causes us to destroy the stream.

Fixes: #34346
    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    0865a22 View commit details
    Browse the repository at this point in the history

  2. streams: fix 2nd instance

    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    851667e View commit details
    Browse the repository at this point in the history

  3. add a link to the bug, by request

    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    f646c23 View commit details
    Browse the repository at this point in the history

  4. add a test that crashes without the fix.

    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    eea77a5 View commit details
    Browse the repository at this point in the history

  5. fix linter error

    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    98daa59 View commit details
    Browse the repository at this point in the history

  6. add extra check in stream_base.cc to be extra sure.

    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    1440eae View commit details
    Browse the repository at this point in the history

  7. undo "nice to have" which breaks some tests (sorry)

    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    965c0b4 View commit details
    Browse the repository at this point in the history

  8. give up on asserting that everyone sees the same error

    @robey
    robey committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    27bc342 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. make a guess about why new tests are failing

    @robey
    robey committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    4663458 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. try removing the test completely

    @robey
    robey committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    251a8c9 View commit details
    Browse the repository at this point in the history