Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove common.localhostIPv6 #34373

Closed
wants to merge 0 commits into from
Closed

test: remove common.localhostIPv6 #34373

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 14, 2020 •
edited
Loading

common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 14, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 14, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32351/ ✅

@Trott Trott changed the title test: remove common.localhostIPv6() test: remove common.localhostIPv6 Jul 15, 2020
@Trott
Copy link
Member Author

Trott commented Jul 15, 2020

Note to self: When landing, we should remove () from the commit message.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 15, 2020
Trott added a commit that referenced this pull request Jul 16, 2020
@Trott
test: remove common.localhostIPv6
bf0d82c 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 16, 2020

Landed in bf0d82c

@Trott Trott closed this Jul 16, 2020
@Trott Trott deleted the remove-unused branch July 16, 2020 23:59
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott @cjihrig
test: remove common.localhostIPv6
ad8bdf0 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@Trott @MylesBorins
test: remove common.localhostIPv6
699da05 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: remove common.localhostIPv6
36c7abf 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: remove common.localhostIPv6
95b2a39 
common.localhostIPv6 is almost entirely unused and is unnecessary.
Remove it.

PR-URL: #34373
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @lpinca @targos @richardlau @trivikr