-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: refactor CertCbDone to avoid goto statement #34325
Closed
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:src-refactor-certcbdone-to-avoid-goto
Closed
src: refactor CertCbDone to avoid goto statement #34325
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:src-refactor-certcbdone-to-avoid-goto
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
Jul 12, 2020
nodejs-github-bot
added
the
crypto
Issues and PRs related to the crypto subsystem.
label
Jul 12, 2020
jasnell
approved these changes
Jul 12, 2020
bnoordhuis
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there's still plenty of room for further simplification because the cb(arg)
call always ends up invoking TlsWrap::OnClientHelloParseEnd()
.
Might as well cut out the middle man, it's just needless indirection.
tniessen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jul 17, 2020
tniessen
added a commit
that referenced
this pull request
Jul 19, 2020
PR-URL: #34325 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Landed in a6ba8de, thank you for reviewing. |
tniessen
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jul 19, 2020
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
PR-URL: #34325 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
PR-URL: #34325 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34325 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34325 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my understanding of
FunctionTemplate::HasInstance
,cons->HasInstance(ctx)
should returnfalse
ifctx
is not an object, and this should be functionally equivalent to the previous code.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes