Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: fix nested uncaught exception handling #34310

Closed
wants to merge 2 commits into from
Closed

worker: fix nested uncaught exception handling #34310

wants to merge 2 commits into from

Commits on Jul 11, 2020

  1. worker: fix nested uncaught exception handling 

    We are using `ObjectPrototypeToString()` as a cross-context brand check
for built-in errors, but weren’t making sure to set that when
deserializing errors back into JS objects.

Fix that by setting `[Symbol.toStringTag]` manually, to make sure that
multiple serialize-and-deserialize cycles keep giving the same result.

Fixes: nodejs#34309
    @addaleax
    addaleax committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    a079590 View commit details
    Browse the repository at this point in the history

  2. fixup! worker: fix nested uncaught exception handling

    @addaleax
    addaleax committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    ee7775a View commit details
    Browse the repository at this point in the history