-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add pummel tests to ci runs #34289
Conversation
This comment has been minimized.
This comment has been minimized.
ASAN check failed with, since it works in normal test, we may need to skip it in asan, like in node/test/parallel/test-crypto-dh-leak.js Lines 7 to 8 in d5e1795
Fail log: AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert.ok(maxMem < 64 * 1024 * 1024)
at process.<anonymous> (/home/runner/work/node/node/test/pummel/test-vm-memleak.js:61:10)
at process.emit (events.js:326:22) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}
Command: out/Release/node --max_old_space_size=32 /home/runner/work/node/node/test/pummel/test-vm-memleak.js |
This comment has been minimized.
This comment has been minimized.
Same test failed on AIX. https://ci.nodejs.org/job/node-test-commit-aix/31507/nodes=aix71-ppc64/testReport/junit/(root)/test/pummel_test_vm_memleak/ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
on macOS, not sure flaky Also assert.js:103
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
false !== true
at Timeout._onTimeout (/Users/runner/work/node/node/test/pummel/test-timers.js:55:10)
at listOnTimeout (internal/timers.js:555:17)
at processTimers (internal/timers.js:498:7) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: 'strictEqual'
}
Command: out/Release/node /Users/runner/work/node/node/test/pummel/test-timers.js |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The pummel tests result in the Windows coverage runs in CI to exhaust memory, so we need to bump up the heap size. PR-URL: nodejs#34289 Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#34289 Reviewed-By: Richard Lau <[email protected]>
Landed in 6a1986d...2853b76 |
These tests take quite a long time on the Raspberry Pis (and sometimes fail with a timeout). Could we disable pummel tests on |
Looking at Pi 2 results in https://ci.nodejs.org/job/node-test-binary-arm-12+/10400/, the longest running tests (and how long it took them to run in seconds) are:
I think it makes sense to:
I'll get to work on this tonight and hopefully have a PR together quickly. |
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: nodejs#34289 (comment)
Move slower tests to pummel and skip on Raspberry Pi devices in CI. Refs: nodejs#34289 (comment)
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: nodejs#34289 (comment) PR-URL: nodejs#38394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Move slower tests to pummel and skip on Raspberry Pi devices in CI. Refs: nodejs#34289 (comment) PR-URL: nodejs#38395 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Move slower tests to pummel and skip on Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38395 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
The check for an 800ms window makesw assumptions about a setTimeout() not running late etc. Remove it. Refs: #34289 PR-URL: #38060 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
The test is too slow to run on the Raspberry Pi bots. (It takes over 500 seconds to run on Pi 3 bots and over 900 seconds on Pi 2 bots.) Skip it on armv6 and armv7. Refs: #34289 PR-URL: #38076 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
The test is too slow to run on the Raspberry Pi bots. (It takes over 900 seconds to run on Pi 3 bots and even more than that on Pi 2 bots.) Skip it on armv6 and armv7. Refs: #34289 PR-URL: #34289 Reviewed-By: Richard Lau <[email protected]>
ASAN increases memory usage, which in turn messes up the memory leak test. Skip the test on ASAN. PR-URL: #34289 Reviewed-By: Richard Lau <[email protected]>
The test is too slow to run on the Raspberry Pi bots. (It takes over 900 seconds to run on Pi 3 bots and even more than that on Pi 2 bots.) Skip it on armv6 and armv7. Refs: #34289 PR-URL: #34289 Reviewed-By: Richard Lau <[email protected]>
ASAN increases memory usage, which in turn messes up the memory leak test. Skip the test on ASAN. PR-URL: #34289 Reviewed-By: Richard Lau <[email protected]>
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Skipped the longest-running pummel tests on the Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Force garbage collection so that the memory leak is more easily differentiated from ordinary not-garbage-collected memory. Refs: #34289 PR-URL: #38054 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes